Recently, I went to RailsConf. I saw a bunch of talks and met some cool people. This is not a RailsConf post-mortem post (if you’re interested, though, I’ve collected some notes from myself and some others here). This post is about what, in retrospect, was probably the best talk I went to (and I went to several really awesome talks). I’ve been mulling over it since I got back, basically, and that seems like a good result from a talk. That talk was Avdi Grimm’s Confident Code (slides, my notes).
One thing in particular sort of caught at the edge of my thought patterns: The Null Object Pattern. I don’t have a CS degree and so I’m missing a lot of the formal training about design patterns that many programmers have (and, probably, forget), so I’d never heard of it. When Avdi started talking about how ActiveRecord’s
try method is a code smell, I was like, “Yes!” I would not say that I hate it, but I have seen several times some line of code that looks like this:
I mean… bleh. But I didn’t know a way that looked any better to me, really. Anyway, you can look at the notes and slides to learn about what Avdi says about the Null Object Pattern. I thought it was awesome and so when I went home, I decided to take it for a test drive.
The Test Course
So in a project at work, we have Users and they may or may not have one Subscription. Hopefully, you can picture this complex object graph. Subscriptions may or may not be “current” based on various business rules mostly to do with whether you paid us or not. So, naturally, we have a
Subscrption#current? method. But we’re using the User as a sort of presenter for Subscriptions. So you don’t want to call
@user.subscription.current?. That’s a code smell. So on User we had this method:
1 2 3
There’s that rascal
try. “This,” I thought, “is a perfect spot for that
Maybe method from Avdi’s talk.” So I rewrote it thusly:
1 2 3
W00t, right? Wrong. The accompanying
NullObject class looks like this:
1 2 3 4 5 6 7 8 9
That method missing treatment, so handy in avoiding the chain of
trys in my first example, is the gotcha. It means that if I have a User without a Subscription for whatever reason, calling
User#current? returns an instance of
NullObject, which will pass, say, the boolean clause of an
So, not sure as to whether I’d misunderstood something, was making some dumb mistake or what, I emailed Avdi. He said, basically, “Awesome question. I will answer it in a blog post.” And, lo, he did. Go read that post to see what he said. The comments also have some good ideas.
If you read my comment, I said I was going to noodle on stuff and post again. I had more thoughts than it seemed like would fit in a blog comment. Hence this post. So my initial thought was disappointment. It turned out the Null Object Pattern wasn’t as powerful (in Ruby) as I’d hoped, since if you might have something (calling
Maybe) the chances that you’ll have some conditional asking a boolean business-rule question about it is not low.
So I thought about how to get around that. You could, for instance, make a more complex
method_missing definition that grepped the message name for
/\?$/ and returned false. That’s fail, though. It falls down the moment you have something like this:
1 2 3
But then I realized that Avdi was making a higher-level point: since it is not possible to make your own objects look falsey in Ruby, you have to have another solution. Trying to define various question-mark methods on
NullObject is trying to untie the knot, but I should be looking for a way to cut it. So it got me thinking: Why the hell do I have Users without Subscriptions, anyway? Shouldn’t
User#current? express that business logic clearly, rather than just express the logic that enforces it? Yes. Yes, it should.
We have some Users who are also admins, who have special rights. It’s also conceivable that we could give away a free account for whatever reason. So, really, we want something like this:
1 2 3
But, this thought it incomplete. It expresses the business logic cleanly: The User is current if they’re flagged as free or if their Subscription is up to date. However, if the weird case of a User who is neither free nor has an associated Subscription crops up, we still have to hunt down the “Undefined method ‘current?’ for nil” error. It sort of has me reaching for
Or maybe (heh, you see what I did there) I want to steal another trick from Avdi’s presentation and have
:no_subscription_defined_for_user so that the error message makes some more sense. I don’t like redefining
ActiveRecord’s default accessor methods, though, to transparently return the symbol if the real object is missing.
If you’ve got any thoughts, I’d love to hear them.